Profile cover photo
Profile photo
Simon Marquis
Diplômé de TELECOM Nancy (école d'ingénieur en informatique, anciennement ESIAL). Actuellement Ingénieur Développement mobile chez SightCall.
Diplômé de TELECOM Nancy (école d'ingénieur en informatique, anciennement ESIAL). Actuellement Ingénieur Développement mobile chez SightCall.
About
Simon's interests
View all
Simon's posts

Post is pinned.Post has attachment
Update v1.8.2 is live:
☑ Switched to libsuperuser as internal library to support busybox, toybox, toolbox, etc.

Hi +Koushik Dutta,

Please find an updated version of my feedbacks:

Version 1.0.0.9 (1469779200)

SharingActivity:
- Should not open up the softkeyboard

AccessingActivity:
- The ok button on the keyboard should click on ACCESS button

Typo:
- Copied link to clipboard -> Link copied to clipboard

Notification:
- use the launcher icon as largeIcon and the current contact icon as smallIcon
- smallIcon represents a contact with a phone (you can find something better than that)
- Don't use the app name as contentTitle: not recommended, and in Android N it is duplicated
- Use setUsesChronometer on the notification to keep track of the time spent sharing the screen
- When ViewScreenActivity is not in foreground change the notification contentText to "Press to return to the sharing" or similar
- Stop icon is not meaningful here (cross instead of the black square)
- Notification action icons should reflect the action, not the current state to be in sync with the notification action text (mute/unmute icon is inverted)
- Stop action on the receiver side would be appreciated
- If ViewScreenActivity is being destroyed, clicking the notification will open the StartActivity instead of ViewScreenActivity

Improvements:
- Add a default title/subject to the Intent when sharing the link
- StartActivity could be replaced by something more meaningfull when session is in progress
- Enable multi-touch
- Keep the pointer displayed when the finger is not moving
- Add a long press action to emphasize on something to click for instance (with ripple effect)
- Whenever the sharing session ends, or the Cast feature is being manually cleared (from the notification panel) the app should return to the StartActivity or terminate the current sharing session to avoid crash
- If the session is stopped and the receiver is not currently on ViewScreenActivity, the notification remains displayed

Bugs:
- Click on STOP will turn microphone on for a second before the stream ends!
- Screen rotation on the sharing side will automatically turn microphone on!
- Screen rotation landscape to portrait (from Nexus 10 to Nexus 6, same behaviour reversed) blocks the sharing (virtual display encoder issue), cf links below

http://pastebin.com/faCFV7yM - Sender side
http://pastebin.com/Lhs5iyFL - Receiver side

Hi +Koushik Dutta

Awsome app!
After playing with this app, please find some improvements that could be made, crashes I've experienced, etc.


Enter Access Code:
- Why is it "Waiting for connection..." since the user connects only when clicking the "access" button?
- Auto focus the next EditText after 4chars are entered.

Screensharing started:
- the "Your screen is beeing shared" page is browsable from the recents but it really shouldn't
- If the user cancels the Virtual Display system popup, screensharing should be aborted

Screensharing:
- No "STOP" button on the remote side
- lots of packet loss (not all touch events are reported) results also in increased delayed in touch event
- ANR after multiple touch events. Results in lot of similar logs
07-22 11:00:31.040 296-296/? W/Layer: [SurfaceView - com.koushikdutta.inkwire/com.koushikdutta.inkwire.ViewScreenActivity] Timestamp 135949405000000 seems implausible relative to expectedPresent 69144762460508
- annotations not avaliable on the notification shade nor the lockscreen
- when pointer is down, the dot on the remote should remain visible
- Killing the virtual display from notificiation shade doesn't stop the screencast
- Pressing back when receiving the screenshare produces a crash
<stacktrace>
07-22 13:54:49.122 9214-9214/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.koushikdutta.inkwire, PID: 9214
android.view.WindowManager$BadTokenException: Unable to add window -- token android.os.BinderProxy@ff8c9fc is not valid; is your activity running?
at android.view.ViewRootImpl.setView(ViewRootImpl.java:678)
at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:342)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:93)
at android.app.Dialog.show(Dialog.java:316)
at com.koushikdutta.inkwire.ViewScreenActivity$7$3$1.run(ViewScreenActivity.java:390)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6077)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)
</stacktrace>
- The screenshare receiver should be able to press back during screensharing
- The screenshare receiver should be able to return to the sharing page when pressing the notification

Misc:
- Landscape version of the whole UI is missing
- crash when reusing the same code:
<stacktrace>
07-22 11:03:39.246 27376-30055/? E/rtc: #
# Fatal error in ../../webrtc/base/event_tracer.cc, line 239
# last system error: 0
# Check failed: rtc::AtomicOps::CompareAndSwapPtr( &g_event_logger, static_cast<EventLogger*>(nullptr), new EventLogger()) == nullptr
#
#
07-22 11:03:39.246 27376-30055/? A/libc: Fatal signal 6 (SIGABRT), code 6 in tid 30055 (AsyncServer)

[ 07-22 11:03:39.247 269: 269 W/ ]
debuggerd: handling request: pid=27376 uid=10104 gid=10104 tid=30055
07-22 11:03:39.323 30056-30056/? A/DEBUG: * * * * * * * * * * * * * * * *
07-22 11:03:39.323 30056-30056/? A/DEBUG: Build fingerprint: 'google/shamu/shamu:7.0/NPD90G/3051502:user/release-keys'
07-22 11:03:39.323 30056-30056/? A/DEBUG: Revision: '0'
07-22 11:03:39.323 30056-30056/? A/DEBUG: ABI: 'arm'
07-22 11:03:39.323 30056-30056/? A/DEBUG: pid: 27376, tid: 30055, name: AsyncServer >>> com.koushikdutta.inkwire <<<
07-22 11:03:39.323 30056-30056/? A/DEBUG: signal 6 (SIGABRT), code 6 (SI_TKILL), fault addr ------
07-22 11:03:39.323 30056-30056/? A/DEBUG: r0 00000000 r1 00007567 r2 00000006 r3 00000008
07-22 11:03:39.324 30056-30056/? A/DEBUG: r4 907ff978 r5 00000006 r6 907ff920 r7 0000010c
07-22 11:03:39.324 30056-30056/? A/DEBUG: r8 0000000a r9 93123931 sl 90fcd88c fp 907fef44
07-22 11:03:39.324 30056-30056/? A/DEBUG: ip 00000000 sp 907feda0 lr acc03517 pc acc05d80 cpsr 60050010
07-22 11:03:39.331 30056-30056/? A/DEBUG: backtrace:
07-22 11:03:39.331 30056-30056/? A/DEBUG: #00 pc 00049d80 /system/lib/libc.so (tgkill+12)
07-22 11:03:39.331 30056-30056/? A/DEBUG: #01 pc 00047513 /system/lib/libc.so (pthread_kill+34)
07-22 11:03:39.331 30056-30056/? A/DEBUG: #02 pc 0001d615 /system/lib/libc.so (raise+10)
07-22 11:03:39.331 30056-30056/? A/DEBUG: #03 pc 00019161 /system/lib/libc.so (__libc_android_abort+34)
07-22 11:03:39.331 30056-30056/? A/DEBUG: #04 pc 00017028 /system/lib/libc.so (abort+4)
07-22 11:03:39.331 30056-30056/? A/DEBUG: #05 pc 00096223 /data/app/com.koushikdutta.inkwire-1/lib/arm/libjingle_peerconnection_so.so
07-22 11:03:39.332 30056-30056/? A/DEBUG: #06 pc 00096dc1 /data/app/com.koushikdutta.inkwire-1/lib/arm/libjingle_peerconnection_so.so
07-22 11:03:39.332 30056-30056/? A/DEBUG: #07 pc 004f9895 /data/app/com.koushikdutta.inkwire-1/oat/arm/base.odex (offset 0x49d000)
</stacktrace>


Post has attachment
Update v2.0 is live:
☑ Improve overall performance

Post has attachment
Preferences Manager update v1.8 is live:
 ☑ RootTools framework to improve performance
 ☑ Holo Dark theme
 ☑ FloatLabelLayout +Chris Banes 

Post has attachment
Preferences Manager update v1.8 is live:
 ☑ RootTools framework to improve performance
 ☑ Holo Dark theme
 ☑ FloatLabelLayout +Chris Banes 

Update v1.8 is live:
 ☑ RootTools framework to improve performance
 ☑ Holo Dark theme
 ☑ FloatLabelLayout +Chris Banes 

Post has attachment
Hi,
If you are an Android developer, here's an app made ​​for you: `Preferences Manager`
It allows Android developers to view and edit the preferences of all their Android apps.
It's really useful to debug your app during development.

Last update v1.7 adds:
☑ Creating shortcuts
☑ Backup and Restore preferences
☑ UI Enhancements

My app is Open Source, available on Github https://github.com/SimonMarquis/Android-PreferencesManager, so feel free to suggest improvements or request features ;)

Post has attachment
Here is an application made ​​for developers: `Preferences Manager`
It allows developers to view and edit the preferences of all their Android apps.
It's really useful to debug your app during development.

Last update v1.7 adds:
☑ Creating shortcuts
☑ Backup and Restore preferences
☑ UI Enhancements

My app is Open Source, available on Github, so feel free to suggest improvements or request features ;)

Post has attachment
Here is an application made ​​for developers: `Preferences Manager`
It allows developers to view and edit the preferences of all their Android apps.
It's really useful to debug your app during development.

Last update v1.7 adds:
☑ Creating shortcuts
☑ Backup and Restore preferences
☑ UI Enhancements

My app is Open Source, available on Github https://github.com/SimonMarquis/Android-PreferencesManager, so feel free to suggest improvements or request features ;)
Wait while more posts are being loaded