Profile

Cover photo
Chris Broadfoot
Works at Google
Attended University of New South Wales
Lived in Sydney
11,968 followers|705,059 views
AboutPostsPhotosYouTubeReviews

Stream

 
Pumped to talk at Google I/O this year with +Ankur Kotwal.

It's basically a tech talk on how we built Santa Tracker using a lot of the Google developer platform.

There's some great (technical) anecdotes in it, so please come along if you're attending I/O, or watch the recording afterwards on YouTube.

#santatracker #io14  

https://www.google.com/events/io/schedule/session/a578141e-b6bf-e311-b297-00155d5066d7
21
1
Teresa Lam's profile photoJoe Wehry's profile photo
2 comments
 
Even tho' not a developer, this was  very interesting presentation! Thanks.  (Looking forward to Santa this year - hope you keep the candy cane game.)
Add a comment...

Chris Broadfoot

Shared publicly  - 
 
Aperol spritz by Sydney Harbour
13
narayan pokharel's profile photo
 
like this
Add a comment...
 
Sydney sunrise #pano
41
1
kumaravel v's profile photoBen Stewart's profile photoStephen Yuen's profile photoDylan Floyd's profile photo
10 comments
 
Nice 
Add a comment...
 
 
Next time you're in India, find your way around popular malls and shopping centres more easily with indoor #GoogleMaps

See where indoor maps are available: goo.gl/TJ15mL.

iPhone users: Get the app at goo.gl/4oENi.
15
1
Nichoy Scott's profile photoAugustine Correa's profile photo
 
Hi chris
Add a comment...

Chris Broadfoot

Shared publicly  - 
 
What is the best code review tool for GitHub projects?

The ideal tool would:
* have code reviews should happen on the pull-request level, not on an individual git commit level.
* provide diffs between subsequent commits added to the pull request.
* have a way to "resolve" comments added by reviewers, and show the reviewers a diff that illustrates that a fix was applied.
* auto-merge when a "LGTM" or approval is given by a project owner
7
1
Chris Broadfoot's profile photoOmer Younus's profile photoMark Derricutt's profile photoGabor Orosz's profile photo
6 comments
 
Meld
Add a comment...
 
Sarah wrote a great blog post on writing sample code for the Android Maps Utility Library
 
While creating some sample code this week, it struck me that it's an interesting process. So I've blogged about it. I'd love your additions to my jottings!
11
2
Rob G's profile photoDamian Flannery's profile photo
Add a comment...
Have him in circles
11,968 people
 
My dad, on Google driverless cars:
"They should study Thailand: most of the cars here already operate without drivers!!"
13
1
Tim Bondy's profile photo
Add a comment...
7
Add a comment...
 
Writing correct concurrent Java code is hard

See if you can spot what's wrong with this code I came across today, simplified here*:

class Foo {
Boolean myFlag = Boolean.valueOf(false);

void foo() {
  synchronized(myFlag) {
    ...
    myFlag = Boolean.valueOf(true);
  }
}

void bar() {
  synchronized(myFlag) {
    myFlag = Boolean.valueOf(false);
  }
}

Let me first provide a brief explanation of how the synchronized statement works in Java. Every Object has an intrinsic lock associated with it. The synchronized statement obtains the lock associated with the object, runs the code inside the block, then releases the lock.

In this case, the synchronized statement obtains the lock associated with the object in the "myFlag" field. The programmer has recognized that you can't lock over a primitive type (boolean), so has opted to use Boolean (which is a subclass of Object).

There are two things wrong in this example:
1) the value of the "myFlag" field is reassigned. In this case, it has one of two values: Boolean.TRUE and Boolean.FALSE.
2) if any code running in any thread also locks over either of these easily accessible values, the code running from this class is affected.

Three rules to prevent this mistake in your own Java code:
1) If possible, use synchronized methods instead of synchronized statements (they're simpler)
2) Only lock over fields marked as final, or the "this" object.
3) Create separate lock objects for fields that need this block, and in your source file, write a comment stating that as a contract. For example:
private final Object myFlagLock = new Object();
private boolean myFlag = false; // must synchronize on "myFlagLock".

In this case, an AtomicBoolean would work quitenicely, too:
private final AtomicBoolean myFlag = new AtomicBoolean(false);
synchronized(myFlag) {
   myFlag.set(true);
   ...
}

I've noticed that IntelliJ provides an inspection for this simple mistake. I can't recommend IntelliJ enough.

Read more about the synchronized statement/block here:
http://docs.oracle.com/javase/tutorial/essential/concurrency/locksync.html

Get the fantastic "Java Concurrency in Practice" book by +Joshua Bloch and others:
http://amzn.com/0321349601

* Full code was from the Pebble SDK examples, found here: http://goo.gl/CDxPMA

#java   #concurrency  
36
10
Boyd Smith's profile photoSalvador Gómez's profile photoZhelyazko Atanasov's profile photoZheka Kozlov's profile photo
9 comments
 
+Chris Broadfoot It was +Boyd Smith's idea!
Add a comment...

Chris Broadfoot

Shared publicly  - 
 
 
Fans of lipids and cutlery rejoice, Butter Knife v5.0 has been released! Read on and learn about what's new:

@InjectViews
Views are frequently operated on in groups as a result of some event. Text views animate in on new screens, input fields are enabled and disabled for network calls, etc. Group multiple views together using the @InjectViews annotation into a List or array for easy operation.

  @InjectViews({ R.id.first_name, R.id.last_name })
  List<TextView> nameViews;

ButterKnife.apply
Coupled with the aforementioned annotation to aggregate views, apply provides a concise way to operate on those groups of views at once.

  ButterKnife.apply(nameViews, DISABLE);
  ButterKnife.apply(nameViews, ENABLED, false)

The Action[1] and Setter[2] interfaces provide easy ways to define operations.

  static final Action<View> DISABLE = new Action<>() {
    @Override public void apply(View view, int index) {
      view.setEnabled(false);
    }
  }
  static final Setter<View, Boolean> ENABLED = new Setter<>() {
    @Override public void set(View view, Boolean value, int index) {
      view.setEnabled(value);
    }
  }

You can use Android's Property[3] with apply as well.

  ButterKnife.apply(nameViews, View.ALPHA, 0);

New multi-callback listeners
* @OnItemSelected for AdapterView.OnItemSelectedListener's onItemSelected callback.
* @OnPageChange for ViewPager.OnPageChangeListener's onPageChange callback.
* @OnTextChange for TextWatcher's onTextChange callback.

Each of these new listeners have multiple callback methods. Change which callback your method is being bound to by supplying a callback argument.

  @OnItemSelected(R.id.list)
  void onItemSelected(long id) {
    // ...
  }

  @OnItemSelected(value= R.id.list, callback = NOTHING_SELECTED)
  void onNothingSelected() {
    // ...
  }

Enjoy! And #DeathToBoilerplate !

* Website: http://jakewharton.github.io/butterknife/
* Changelog: https://github.com/JakeWharton/butterknife/blob/master/CHANGELOG.md
* Javadoc: http://jakewharton.github.io/butterknife/javadoc/


[1]: http://jakewharton.github.io/butterknife/javadoc/butterknife/ButterKnife.Action.html
[2]: http://jakewharton.github.io/butterknife/javadoc/butterknife/ButterKnife.Setter.html
[3]: https://developer.android.com/reference/android/util/Property.html
7
2
Ian Douglas's profile photoEric Cochran's profile photoDevi Maharani's profile photo
 
Hello
Add a comment...

Chris Broadfoot

Shared publicly  - 
 
I hosted two interns this summer with +Anthony Morris  - check out their awesome work :-)
 
Marker clustering and heatmaps on Android
Check out new ways to visualize large amounts of geo data in your Android app. Read through the blog post for more info!
30
8
Masashi Katsumata's profile photoBenoit Billington's profile photoStephen Yuen's profile photoDamian Flannery's profile photo
2 comments
 
Yap...... thts good..... big up 4 u
Add a comment...

Chris Broadfoot

Shared publicly  - 
 
Hansel. So hot right now
 
Apparently the +Google Maps API Eng team is one of the hottest trends at local dining establishments.  Look who I spotted in the SF Chronicle +Enoch Lau  +James McGill +Dave Day +Dilshan Angampitiya +Luke Mahe +Chris Broadfoot +Marcelo Camelo +Mike Perrow +David Wang http://www.sfgate.com/restaurants/slideshow/21-trends-of-the-hottest-local-dining-and-78445/photo-5413034.php
8
ojo greatsamuel's profile photo
 
Thanks
Add a comment...
People
Have him in circles
11,968 people
Work
Occupation
Developer Relations, Google
Employment
  • Google
    Developer Programs Engineer, 2010 - present
  • Atlassian
    Developer, 2008 - 2009
Places
Map of the places this user has livedMap of the places this user has livedMap of the places this user has lived
Previously
Sydney
Story
Tagline
Google Developer Relations (Android Maps)
Introduction

Developer Relations, Google Maps APIs

Currently focused on Google Maps Android API.

Education
  • University of New South Wales
Basic Information
Gender
Male
We waited 45 minutes for the wrong pizza, service was very slow because all the staff were talking amongst themselves.
Public - 2 years ago
reviewed 2 years ago
Absolutely terrible service. Decent food. Would not recommend.
Public - 3 years ago
reviewed 3 years ago
2 reviews
Map
Map
Map